-
Notifications
You must be signed in to change notification settings - Fork 69
chore: Update the upper bound dependencies file #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This PR updates several dependencies in dependencies.txt
. The changes are straightforward and look good. I've added a few minor suggestions to improve the consistency of the comments.
🔍 General Feedback
- The added comments are helpful for clarifying the purpose of the different opentelemetry dependencies.
- The dependency updates are consistent with the goal of keeping the project up-to-date.
google.http-client=1.47.1 | ||
gson=2.13.1 | ||
guava=33.4.8-jre | ||
protobuf=4.31.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition for clarity.
{{SEVERITY}} low
httpcomponents.httpcore=4.4.16 | ||
httpcomponents.httpclient=4.5.14 | ||
apache-httpclient-5=5.5 | ||
apache-httpcore-5=5.3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be slightly more consistent to phrase this comment like the others, for example: "Note: This opentelemetry version refers to the opentelemetry-bom, not the opentelemetry-exporter."
{{SEVERITY}} low
apache-httpcore-5=5.3.4 | ||
perfmark-api=0.27.0 | ||
# Note: This is the google opentelemetry exporter and not the general opentelemetry project | ||
google.cloud.opentelemetry=0.36.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be clearer to say "The following opentelemetry dependencies..." for better readability.
{{SEVERITY}} low
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be worth adding a summary in the PR description on which dependencies have been updated in the dependency compatibility job.
done |
Updates to the following upper bound dependency versions: ``` j2objc-annotations=3.1 threetenbp=1.7.2 google.api-client=2.8.1 opentelemetry-semconv=1.34.0 ```
Updates to the following upper bound dependency versions: