Skip to content

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Aug 19, 2025

Updates to the following upper bound dependency versions:

j2objc-annotations=3.1
threetenbp=1.7.2
google.api-client=2.8.1
opentelemetry-semconv=1.34.0

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 19, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates several dependencies in dependencies.txt. The changes are straightforward and look good. I've added a few minor suggestions to improve the consistency of the comments.

🔍 General Feedback

  • The added comments are helpful for clarifying the purpose of the different opentelemetry dependencies.
  • The dependency updates are consistent with the goal of keeping the project up-to-date.

google.http-client=1.47.1
gson=2.13.1
guava=33.4.8-jre
protobuf=4.31.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition for clarity.

{{SEVERITY}} low

httpcomponents.httpcore=4.4.16
httpcomponents.httpclient=4.5.14
apache-httpclient-5=5.5
apache-httpcore-5=5.3.4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be slightly more consistent to phrase this comment like the others, for example: "Note: This opentelemetry version refers to the opentelemetry-bom, not the opentelemetry-exporter."

{{SEVERITY}} low

apache-httpcore-5=5.3.4
perfmark-api=0.27.0
# Note: This is the google opentelemetry exporter and not the general opentelemetry project
google.cloud.opentelemetry=0.36.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be clearer to say "The following opentelemetry dependencies..." for better readability.

{{SEVERITY}} low

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also be worth adding a summary in the PR description on which dependencies have been updated in the dependency compatibility job.

@lqiu96
Copy link
Member Author

lqiu96 commented Aug 19, 2025

It might also be worth adding a summary in the PR description on which dependencies have been updated in the dependency compatibility job.

done

@lqiu96 lqiu96 merged commit a660a86 into main Aug 19, 2025
60 of 61 checks passed
@lqiu96 lqiu96 deleted the update-dependencies-txt-file branch August 19, 2025 18:47
lqiu96 added a commit that referenced this pull request Aug 21, 2025
Updates to the following upper bound dependency versions:
```
j2objc-annotations=3.1
threetenbp=1.7.2
google.api-client=2.8.1
opentelemetry-semconv=1.34.0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants